Match MSTest overloads against the test data - #1862
Merged
Merged
Conversation
FindMethod returned the first method whose name matched, so with overloaded test methods every case resolved to the same MethodInfo. Two ways that goes wrong: * The parameter count guard in BuildVerifier compares the data length against that MethodInfo, so it mismatches for the other overload and SetParameters is silently skipped, dropping the parameters from the file name. * The parameter names handed to InnerVerifier come from that MethodInfo, so a same arity overload is labeled with the other overload's parameter names. The data the test was invoked with is all there is to tell overloads apart, so candidates are now narrowed by parameter count and then by the types of that data. It still falls back to the first match when that does not narrow to one.
This was referenced Aug 26, 2026
This was referenced Aug 31, 2026
Open
Open
Open
legrab
added a commit
to legrab/pocok
that referenced
this pull request
Sep 1, 2026
Updated [Verify.NUnit](https://github.com/VerifyTests/Verify) from 31.28.0 to 32.0.0. <details> <summary>Release notes</summary> _Sourced from [Verify.NUnit's releases](https://github.com/VerifyTests/Verify/releases)._ ## 32.0.0 - [x] [#1832](VerifyTests/Verify#1832) Add Inline snpashot support - [x] [#1835](VerifyTests/Verify#1835) Add SettingsTask.AddContext - [x] [#1847](VerifyTests/Verify#1847) Honor explicit DefaultValueHandling for bools - [x] [#1850](VerifyTests/Verify#1850) Stray extension-less snapshot file crashes every run of its test - [x] [#1851](VerifyTests/Verify#1851) Static UniqueForTargetFramework(Assembly) overloads ignore the assembly passed to them - [x] [#1852](VerifyTests/Verify#1852) Appended files skip scrubbing and newline normalization when a stream converter is registered - [x] [#1853](VerifyTests/Verify#1853) IgnoreParameters() ignore-all sentinel is lost when combined with another ignore source - [x] [#1854](VerifyTests/Verify#1854) Format UTC offsets with the invariant culture - [x] [#1855](VerifyTests/Verify#1855) Format UTC offsets with invariant culture - [x] [#1856](VerifyTests/Verify#1856) Use ticks to decide date precision - [x] [#1857](VerifyTests/Verify#1857) Clean # out of file name parameters - [x] [#1858](VerifyTests/Verify#1858) Escape one character trimmed date formats - [x] [#1859](VerifyTests/Verify#1859) Prefer the exact type when resolving a member converter - [x] [#1860](VerifyTests/Verify#1860) Keep empty collections ignored alongside instance predicates - [x] [#1861](VerifyTests/Verify#1861) Key the combinations name cache by reference - [x] [#1862](VerifyTests/Verify#1862) Match MSTest overloads against the test data - [x] [#1863](VerifyTests/Verify#1863) Report deletes as directory relative paths - [x] [#1864](VerifyTests/Verify#1864) Name the guarded API in ThrowIfVerifyHasBeenRun - [x] [#1865](VerifyTests/Verify#1865) Keep stack frames that have no parameter list - [x] [#1866](VerifyTests/Verify#1866) Generate the TestContext property for record test classes - [x] [#1867](VerifyTests/Verify#1867) Fix two CombinationResultsConverter edge cases - [x] [#1868](VerifyTests/Verify#1868) Sign sub-hour UTC offsets - [x] [#1869](VerifyTests/Verify#1869) Write the received file from the stream for handle based FileStreams - [x] [#1870](VerifyTests/Verify#1870) Compare prefixes ignoring case - [x] [#1871](VerifyTests/Verify#1871) Guard the counter value caches with a lock - [x] [#1872](VerifyTests/Verify#1872) Sign sub-hour UTC offsets ## 32.0.0-beta.16 ## 32.0.0-beta.15 ## 32.0.0-beta.14 ## 32.0.0-beta.13 ## 32.0.0-beta.12 ## 32.0.0-beta.10 ## 32.0.0-beta.8 ## 32.0.0-beta.7 ## 32.0.0-beta.6 ## 32.0.0-beta.5 ## 32.0.0-beta.4 ## 32.0.0-beta.3 ## 32.0.0-beta.2 ## 32.0.0-beta.1 Commits viewable in [compare view](VerifyTests/Verify@31.28.0...32.0.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestExecutionContext.FindMethodreturned the first method whose name matchedTestContext.TestName, ignoring parameters. With overloaded test methods every case resolved to the sameMethodInfo, which goes wrong two ways — both reproduced:BuildVerifieronly callsSetParameterswhen the test data length matches thatMethodInfo's parameter count, so for the other overload it silently does not.Overload(int, int)with[DataRow(1, 2)]named its snapshotOverloadTests.Overload.verified.txt— no parameters at all, so every case of that overload collides on one file.InnerVerifiercome from that sameMethodInfo, so a same-arity overload is labeled with the other overload's parameter names.SameArityOverload(int number)with[DataRow(1)]named its snapshot..._text=1, borrowingtextfrom thestringoverload.The data the test was invoked with is all there is to tell overloads apart, so candidates are now narrowed by parameter count (allowing for a params array, whose
DataRowexposes raw pre-binding data) and then by the runtime types of that data. When neither narrows to a single candidate it falls back to the first match, so nothing that resolves today changes.The non-overloaded path is unchanged: a single name match returns immediately, without allocating the candidate list.
OverloadTestscovers both shapes — different arity, and same arity distinguishable only by type. Both produce wrong names onmain.Verify.MSTest.Testspasses for net11.0 and net48 (163), andVerify.MSTestbuilds for all seven target frameworks.